Skip to content
Snippets Groups Projects
Commit f650a898 authored by Camilla Löwy's avatar Camilla Löwy
Browse files

Trust CMake to do the right thing for static libs

CMake understands what private library dependencies for a static library
means and handles it correctly.

(cherry picked from commit f6d44ced)
parent 8c1b59f8
No related branches found
No related tags found
No related merge requests found
...@@ -120,6 +120,7 @@ target_include_directories(glfw PRIVATE ...@@ -120,6 +120,7 @@ target_include_directories(glfw PRIVATE
"${GLFW_SOURCE_DIR}/src" "${GLFW_SOURCE_DIR}/src"
"${GLFW_BINARY_DIR}/src" "${GLFW_BINARY_DIR}/src"
${glfw_INCLUDE_DIRS}) ${glfw_INCLUDE_DIRS})
target_link_libraries(glfw PRIVATE ${glfw_LIBRARIES})
# HACK: When building on MinGW, WINVER and UNICODE need to be defined before # HACK: When building on MinGW, WINVER and UNICODE need to be defined before
# the inclusion of stddef.h (by glfw3.h), which is itself included before # the inclusion of stddef.h (by glfw3.h), which is itself included before
...@@ -164,10 +165,6 @@ if (BUILD_SHARED_LIBS) ...@@ -164,10 +165,6 @@ if (BUILD_SHARED_LIBS)
# Hide symbols not explicitly tagged for export from the shared library # Hide symbols not explicitly tagged for export from the shared library
target_compile_options(glfw PRIVATE "-fvisibility=hidden") target_compile_options(glfw PRIVATE "-fvisibility=hidden")
endif() endif()
target_link_libraries(glfw PRIVATE ${glfw_LIBRARIES})
else()
target_link_libraries(glfw INTERFACE ${glfw_LIBRARIES})
endif() endif()
if (MSVC) if (MSVC)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment